Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

typeorm: tests are not closing the connection when failing #168

Open
blumamir opened this issue Aug 1, 2021 · 1 comment
Open

typeorm: tests are not closing the connection when failing #168

blumamir opened this issue Aug 1, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@blumamir
Copy link
Contributor

blumamir commented Aug 1, 2021

typeorm tests are creating a new db connection in each test. If something goes wrong (assertion fails, exception thrown), the test does not close this connection which causes the following tests to fail as well.
We need to move the logic into afterEach hook so tests clean the environment after they are done for whatever reason.
@blumamir blumamir added the good first issue Good for newcomers label Aug 1, 2021
@Madhavkumar-04
Copy link

Madhavkumar-04 commented Oct 19, 2024 •
edited
Loading

hii, can i start working on this
@blumamir

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blumamir @Madhavkumar-04