Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

sequelize instrumentation: authenticate and sync are creating orphaned spans #161

Open
blumamir opened this issue Jul 28, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@blumamir
Copy link
Contributor

Those 2 functions are executing queries on the database.
The queries create sequelize spans that are missing the context of what happened:

  • If called on startup without an active trace, they will just be generated as a single-span-trace which is lacking any clue about what caused it and why it was created (the query is something like SELECT 1+1 AS result)
  • If called while there is an active trace, then the trace will have those span as child of some other span which can also be confusing.

I suggest to instrument these functions as well, so the instrumentation user will know that a call to authenticate or model.sync happened.

@blumamir blumamir added the good first issue Good for newcomers label Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant