Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: entry_point doesn't override webpack.config if the config contains entry: {} #145

Open
Aghassi opened this issue Mar 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Aghassi
Copy link
Contributor

Aghassi commented Mar 22, 2024

What happened?

If your webpack config contains entry: {} being set, the rule will not override even if you pass entry_point. You need to pass args --entry-reset and then entry points you care about to do so. This also has the side effect of exposing that args doesn't interpolate and expand format strings. #144 was an attempt to fix this partially, but not a good one.

https://webpack.js.org/api/cli/#entry

Version

Development (host) and target OS/architectures:

Output of bazel --version:
6.4.0

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

Language(s) and/or frameworks involved:

How to reproduce

Create a webpack config with `entry` set
Set a rule that overrides entry with `entry_point`
Bazel run or build that target and see the entry point is not overridden

Pass `args` to the rule that then sets `--entry-reset --entry=<file>` and see it work

Any other information?

No response

@Aghassi Aghassi added the bug Something isn't working label Mar 22, 2024
@github-actions github-actions bot added the untriaged Requires traige label Mar 22, 2024
@jbedard jbedard removed the untriaged Requires traige label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants