Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Requirement that entry_point is below does not work when entry_point is in node_modules package #117

Open
twheys opened this issue Jul 21, 2023 · 0 comments
Labels
bug Something isn't working untriaged Requires traige

Comments

@twheys
Copy link

twheys commented Jul 21, 2023

What happened?

My build has a production optimization step that uses webpack to bundle some node_modules packages. We use the webpack_bundle rule to do this, but in the latest version, 0.12.0, a validation error is raised preventing this, which requires that the entrypoint is relative to the build package.

Error in fail: Path 'node_modules/.aspect_rules_js/[email protected]/node_modules/styletron-client' is not beneath 'horizon'

I understand the motivation for the validation step but perhaps an exception can be made for node_modules/.aspect_rules_js

Version

rules_webpack 0.12.0

How to reproduce

No response

Any other information?

No response

@twheys twheys added the bug Something isn't working label Jul 21, 2023
@github-actions github-actions bot added the untriaged Requires traige label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged Requires traige
Projects
Status: No status
Development

No branches or pull requests

1 participant