Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Use typescript from npm_translate_lock #624

Open
Silic0nS0ldier opened this issue Jun 6, 2024 · 1 comment
Open

[FR]: Use typescript from npm_translate_lock #624

Silic0nS0ldier opened this issue Jun 6, 2024 · 1 comment
Labels
enhancement New feature or request untriaged Requires traige

Comments

@Silic0nS0ldier
Copy link

Silic0nS0ldier commented Jun 6, 2024

What is the current behavior?

As of #308 the TypeScript version and integrity can be automatically extracted, however this misses out on functionality present in npm_translate_lock such as applying patches.

A recent TypeScript release included a bug microsoft/TypeScript#57849 (5.4.x, broken in 5.4.2 and fixed in 5.4.5) which was fixed with a trivial patch, however it could not be applied to Rules TS's @npm_typescript repo.

Describe the feature

Instead of pulling in TypeScript with bespoke logic

http_archive_version = repository_rule(

support using TypeScript from npm_translate_lock's node_modules directly. This way functionality like patching comes free.

@Silic0nS0ldier Silic0nS0ldier added the enhancement New feature or request label Jun 6, 2024
@github-actions github-actions bot added the untriaged Requires traige label Jun 6, 2024
@Silic0nS0ldier
Copy link
Author

BTW looks like an issue workflow failed to run for this.

https://github.com/aspect-build/rules_ts/actions/runs/9394496432/job/25872315491#step:3:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged Requires traige
Projects
None yet
Development

No branches or pull requests

1 participant