Remove extra files from py_binary DefaultInfo #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors rules_python to ensure that users can use `execpath` with a py_binary target. Fixes aspect-build#455
alexeagle
reviewed
Dec 12, 2024
| @@ -2439,8 +2439,6 @@ drwxr-xr-x 0 0 0 0 Jan 1 2023 ./py/ | |||
| drwxr-xr-x 0 0 0 0 Jan 1 2023 ./py/tests/ | |||
| drwxr-xr-x 0 0 0 0 Jan 1 2023 ./py/tests/py_image_layer/ | |||
| -rwxr-xr-x 0 0 0 2887 Jan 1 2023 ./py/tests/py_image_layer/my_app_bin | |||
| -rwxr-xr-x 0 0 0 16 Jan 1 2023 ./py/tests/py_image_layer/main.py | |||
There was a problem hiding this comment.
it looks to me like this will break the ability to execute a container from this image - the entry point is gone. @thesayyn do you know if we have a test here that the py_image_layer can execute? Do we need to add a TestContainers Cloud or something so we have a docker daemon to run that assertion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors rules_python to ensure that users can use
execpathwith apy_binary target.
Fixes #455