Add types to file generated by __test__.py #428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am adding types to user_args otherwise mypy complains when running
bazel test
.I am trying to automatically run
mypy
when building my bazel targets. I am using rules_mypy for this.I am also using the
py_pytest_main
rule:However, if I run
bazel test mytest
, mypy complains:bazel-out/k8-fastbuild/bin/src/backend2/__test__.py:42: error: Need type annotation for "user_args" (hint: "user_args: list[<type>] = ...") [var-annotated]
.I haven't found a way to remove the
__test__
file frommypy
analysis, and this is actually a simple fix, so I thought we could patch this in.Changes are visible to end-users: yes