Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Simple stand-alone example for a project using rules_py #259

Closed
kopp opened this issue Feb 16, 2024 · 2 comments
Closed

[FR]: Simple stand-alone example for a project using rules_py #259

kopp opened this issue Feb 16, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@kopp
Copy link

kopp commented Feb 16, 2024

What is the current behavior?

The only available example that uses rules_py is within the rules_py repository. Hence the WORKSPACE and BUILD files contain more than what is necessary to just use the rules.

Describe the feature

A simple stand-alone repository, e.g. https://github.com/aspect-build/bazel-examples/tree/main/rules_py/, that contains a minimal application (e.g. one library, one executable), that uses rules_py to define those. It should have at least one external dependency. This should enable users that want to use rules_py to start a project by adapting the given example.

https://github.com/aspect-build/bazel-examples/tree/main/oci_python_image is already quite close, but comes bundled with docker, which adds some more complexity.

@kopp kopp added the enhancement New feature or request label Feb 16, 2024
@github-actions github-actions bot added the untriaged Requires traige label Feb 16, 2024
@alexeagle
Copy link
Member

Our convention is that while examples is in the root WORKSPACE, the e2e/ folders act as standalone examples.

I'll leave this open since I do think we'll add more examples to aspect-build/bazel-examples or bazelbuild/examples as part of 1.0.

@alexeagle alexeagle removed the untriaged Requires traige label Mar 6, 2024
@alexeagle alexeagle added this to the 1.0 milestone Mar 6, 2024
@alexeagle
Copy link
Member

we now have aspect init in our CLI which creates a new minimal rules_py project. I think that's as good as a standalone example. You can look in https://github.com/aspect-build/aspect-workflows-template for the scaffold that's used to stamp out a new project.

@github-project-automation github-project-automation bot moved this to ✅ Done in Open Source Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants