Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Virtual environments to be created next to the target #110

Closed
1 task
psalvaggio-dl opened this issue Dec 6, 2022 · 2 comments · Fixed by #233
Closed
1 task

[FR]: Virtual environments to be created next to the target #110

psalvaggio-dl opened this issue Dec 6, 2022 · 2 comments · Fixed by #233
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@psalvaggio-dl
Copy link

What is the current behavior?

Running a .venv target will create the virtual environment in the root of the repo, with the name .<target>.venv. The virtual environment is not inherently relocatable due to the relative paths inside of first_party.pth.

Describe the feature

Allow for the virtual environments to be created in the same directory as the rule is defined. The current default naming behavior is fine, but adding support for:

bazel run :target.venv env

to name the resulting virtual environment would be great!

Fund our work

@psalvaggio-dl psalvaggio-dl added the enhancement New feature or request label Dec 6, 2022
@rbuckland
Copy link

Yes this would be beneficial.

@jsharpe
Copy link

jsharpe commented Feb 6, 2023

The relative paths also cause issues if you want to package py_binary targets into tar balls using rules_pkg as the output file structure is different to when it is extracted in tree.

@mattem mattem moved this to 📋 Backlog in Open Source Feb 14, 2023
@alexeagle alexeagle added this to the 1.0 milestone Oct 2, 2023
@mattem mattem closed this as completed in ebabbaf Feb 15, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Open Source Feb 15, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Open Source Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants