Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-fs patches performance #668

Closed
jbedard opened this issue Nov 30, 2022 · 2 comments
Closed

node-fs patches performance #668

jbedard opened this issue Nov 30, 2022 · 2 comments
Labels
performance Improve performance of existing features

Comments

@jbedard
Copy link
Member

jbedard commented Nov 30, 2022

@rollup/plugin-node-resolve example: https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1669826690326189

Jest example: aspect-build/rules_jest#50

Potential changes:

@jbedard jbedard self-assigned this Nov 30, 2022
@gregmagolan gregmagolan moved this to 🏗 In progress in Open Source Feb 4, 2023
@gregmagolan
Copy link
Member

@jbedard landed a number of performance improvements to fs-patches but there are still more to come so keeping this open and setting status to "In Progress" in the new Aspect Open Source project

@gregmagolan gregmagolan added enhancement New feature or request performance Improve performance of existing features and removed enhancement New feature or request labels Feb 4, 2023
@gregmagolan gregmagolan moved this from 🏗 In progress to 🔖 Ready in Open Source Feb 4, 2023
@gregmagolan gregmagolan added this to the Performance & Docs milestone Mar 17, 2023
@gregmagolan
Copy link
Member

We measured improvements showing that rules_js is as fast or faster than patches in rules_nodes for executing large test targets. We also heard from users on Bazel Slack that the performance improvements landed have significantly improved their build & test times. For examples, https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1682349811639969?thread_ts=1669826690.326189&cid=CEZUUKQ6P

@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Open Source May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Improve performance of existing features
Projects
Archived in project
Development

No branches or pull requests

2 participants