Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: No longer able to reference js_library's after https://github.com/aspect-build/rules_js/pull/1850 #1918

Open
jrandolf opened this issue Sep 15, 2024 · 1 comment · May be fixed by #1919
Open

[Bug]: No longer able to reference js_library's after https://github.com/aspect-build/rules_js/pull/1850 #1918

jrandolf opened this issue Sep 15, 2024 · 1 comment · May be fixed by #1919
Labels
bug Something isn't working

Comments

@jrandolf
Copy link

What happened?

Before #1850, js_library was linked automatically and could be referenced as :node_modules/package_name. This no longer works.

Version

Development (host) and target OS/architectures: N/A

Output of bazel --version: N/A

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: N/A

Language(s) and/or frameworks involved: JS/TS

How to reproduce

No response

Any other information?

No response
@jrandolf jrandolf added the bug Something isn't working label Sep 15, 2024
@jrandolf jrandolf reopened this Sep 15, 2024
@jrandolf
Copy link
Author

After some debugging, it looks like package.jsons of linked packages are missing at build times if specified in the srcs attribute of js_library.

@jrandolf jrandolf linked a pull request Sep 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: include package.json in npm_sources jrandolf/rules_js
1 participant
@jrandolf