Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: *_update_snapshots target is generated when "snapshots" is set to False #224

Open
fa93hws opened this issue Jan 16, 2024 · 0 comments
Labels
bug Something isn't working untriaged Requires traige

Comments

@fa93hws
Copy link

fa93hws commented Jan 16, 2024

What happened?

The doc says

snapshots: If True, a {name}_update_snapshots binary target is generated

However, from the source code, {name}_update_snapshots will be generated even if snapshots is False
https://github.com/aspect-build/rules_jest/blob/v0.19.6/jest/defs.bzl#L243-L263

Version

Development (host) and target OS/architectures:

Output of bazel --version: 6.4.0 Irrelevant to the issue though.

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: 0.19.6

Language(s) and/or frameworks involved:

How to reproduce

No response

Any other information?

No response

@fa93hws fa93hws added the bug Something isn't working label Jan 16, 2024
@github-actions github-actions bot added the untriaged Requires traige label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged Requires traige
Projects
Status: No status
Development

No branches or pull requests

1 participant