You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a change in behavior introduced between aspect/5.10.15 and aspect/5.10.14 where unresolved lint errors do not cause the aspect lint command to exit with code 1.
The expected behavior is
$aspect --aspect:interactive=false lint //some/target
Aspect //tools/lint:linters.bzl%stylelint of //some/target:target up-to-date:
bazel-out/k8-fastbuild/bin/some/target/target.AspectRulesLintStylelint.patch
bazel-out/k8-fastbuild/bin/some/target/target.AspectRulesLintStylelint.report
bazel-out/k8-fastbuild/bin/some/target/target.AspectRulesLintStylelint.report.exit_code
INFO: Elapsed time: 0.240s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
Lint results for //some/target:target:
/dev/shm/bazel-sandbox.1a614a68dacfa2c8b1a1d1849b65b02f91e493faac9bf43f6f513fd57ca72bbe/linux-sandbox/819/execroot/_main/bazel-out/k8-fastbuild/bin/some/target/styles.css: line 10, col 5, error - Expected "width" to come before "margin-top" in group "Box model" (order/properties-order)
Some problems have automated fixes available:
some/target/styles.css | 2 +-
1 file, 1 insertion(+), 1 deletion(-)
$ echo $?
1
Version
Development (host) and target OS/architectures: Pop!_OS 22.04 LTS
Output of bazel --version: 7.3.1
Version of the Aspect rules, or other relevant rules from your WORKSPACE or MODULE.bazel file: aspect/5.10.15
Language(s) and/or frameworks involved:
How to reproduce
Starting with aspect/5.10.15, the aspect exit code returns 0 even when there is a lint error from one of the linting aspects.
I confirmed that the relevant `AspectRulesLintStylelint.report.exit_code` file contains the correct error code from the underlying linter.
Any other information?
No response
The text was updated successfully, but these errors were encountered:
What happened?
There is a change in behavior introduced between
aspect/5.10.15
andaspect/5.10.14
where unresolved lint errors do not cause theaspect lint
command to exit with code 1.The expected behavior is
Version
Development (host) and target OS/architectures: Pop!_OS 22.04 LTS
Output of bazel --version: 7.3.1
Version of the Aspect rules, or other relevant rules from your
WORKSPACE
orMODULE.bazel
file: aspect/5.10.15Language(s) and/or frameworks involved:
How to reproduce
Any other information?
No response
The text was updated successfully, but these errors were encountered: