Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to delete % of victim #34

Merged
merged 4 commits into from
Jan 25, 2018
Merged

Add option to delete % of victim #34

merged 4 commits into from
Jan 25, 2018

Conversation

Aergonus
Copy link
Collaborator

@Aergonus Aergonus commented Jan 3, 2018

Builds upon #31 and sidesteps #32 (terminate all removes all pods regardless of status)

@asobti
Copy link
Owner

asobti commented Jan 24, 2018

I dont' think this was merged with #33, but it contains a ton of commits. Could you rebase this PR so it only contains the commits that need to be merged

@Aergonus
Copy link
Collaborator Author

It was included!

@asobti
Copy link
Owner

asobti commented Jan 24, 2018

Could you double check. When I look at my master branch, I don't see the kill-mode and killType related code in chaos.go

@asobti
Copy link
Owner

asobti commented Jan 24, 2018

PS - Readme does not have info about the kill-mode changes in the master branch too. I'm not sure this merged with #33

@Aergonus
Copy link
Collaborator Author

See Aergonus#15

@Aergonus
Copy link
Collaborator Author

Oof I'll check it tomorrow on a computer

@Aergonus
Copy link
Collaborator Author

All fixed :)

@asobti asobti merged commit f750ab9 into asobti:master Jan 25, 2018
@Aergonus Aergonus deleted the delete% branch May 18, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants