-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log improvements #24
Merged
Merged
Log improvements #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the client-go docs tutorial https://github.com/kubernetes/client-go/blob/master/tools/clientcmd/doc.go
Converted some logs to their appropriate type (i.e. error to info or vice versa) Reworked schedule print Standardized glog levels `grep -r V\([0-9]\) *` L0: None L1: Highest Level current status info and Errors with Terminations L2: Successful terminations L3: More detailed schedule status info L4: Debugging verbose schedule and config info L5: Auto-resolved inconsequential issues
Allows for fmt.Println(schedule)
Since we should glog the single line info and make the table version isolated and readable
Merged
Aergonus
added a commit
to Aergonus/kube-monkey
that referenced
this pull request
Dec 27, 2017
Only relevant after asobti#24
Aergonus
commented
Dec 27, 2017
@@ -45,6 +47,7 @@ func Run() error { | |||
glog.Fatal(err.Error()) | |||
} | |||
schedule.Print() | |||
fmt.Println(schedule) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would omit this in the final version since it's really intended for someone debugging and expects that this should work
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits contain detailed info which I'll copy below.
tl;dr
Sample output