Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes requested for index.html #179

Closed
UdayVaidya opened this issue Oct 5, 2024 · 3 comments
Closed

changes requested for index.html #179

UdayVaidya opened this issue Oct 5, 2024 · 3 comments

Comments

@UdayVaidya
Copy link

Here’s the revised summary of the changes made to the index.html file, formatted as comments for your pull request (PR) using "you should change" phrasing:

Recommendations for Changes:

  1. Image Path Correction:
    You should change the logo image path in the
    from:
    logo
    to:
    logo
  • This change ensures that the logo image loads correctly across different browsers.
    Accessibility Enhancement:
    You should add an aria-label to the "Back to Top" button for improved accessibility:
  • This helps users relying on assistive technologies understand the button's purpose.
    Code Cleanup:
    You should remove the duplicate for Font Awesome:
  • This reduces redundancy and improves loading efficiency.
  1. Commenting:
    You should add comments in the JavaScript sections to clarify the purpose of specific functions, enhancing maintainability.
    General Improvements:
    You should ensure that all <script> tags are placed at the end of the body for better performance and loading times.
    Testing:
    You should verify that the logo image loads correctly.
    You should confirm that the "Back to Top" button is accessible and functions as intended.
    You should check that the overall layout and functionality remain intact after changes.
Copy link

github-actions bot commented Oct 5, 2024

👋 Thank you for raising an issue! We appreciate your effort in helping us improve. Our team will review it shortly. Stay tuned!

@pameladeysarkar2003
Copy link

please assign me with the task @aslams2020

@aslams2020
Copy link
Owner

@pameladeysarkar2003 Please don't spam on every issue.
The issue assignments are on first come first serve basis...so please don't add comment on each issues in the repo..
As I have seen u adding comments in more than 15 issues so far

Please find some issues by yourself too.
Hope u understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants