Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: _uri_scheme: is read only #248

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Conversation

jkroepke
Copy link
Contributor

In helm-secrets, I'm running the CI with posh shell.

On that shell, I'm getting error like this while running helm-git:

_uri_scheme: is read only

This PR should fixes this.

@aslafy-z
Copy link
Owner

Mmh, weird I didn't catched it. Thank you!

@aslafy-z aslafy-z merged commit fb1f388 into aslafy-z:master Feb 25, 2023
@jkroepke jkroepke deleted the patch-1 branch February 25, 2023 12:01
@jkroepke
Copy link
Contributor Author

The posh is not a shell for operator or end-users. The feature set of the posh shell is really low, however it tries to be 100% POSIX compliant. As I know, the Debian maintainers are using the POSH shell to validate the shell script for POSIX correctness. Thats, why I'm using that shell on my CI.

@aslafy-z
Copy link
Owner

I added some linking with the BusyBox shell inside the CI for this reason, however it looks like it may be not working as expected. I will open an issue to revise that when I get some time. I did not know POSH, will have a look. Thank you for the quick fix!

@aslafy-z
Copy link
Owner

🎉 This PR is included in version 0.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aslafy-z aslafy-z added the released This issue/pull request has been released. label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants