Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

More informative notifcations #810

Closed
Ali1 opened this issue Jun 29, 2017 · 2 comments
Closed

More informative notifcations #810

Ali1 opened this issue Jun 29, 2017 · 2 comments

Comments

@Ali1
Copy link

Ali1 commented Jun 29, 2017

Notifications would be more helpful if details about the trade were also sent such exactly how much ends up being traded.

This is possible if the trader module is running before the notifying modules such as mailer.

Is it? If so, is it worth exploring how the trader module could log the exact details of the trade to be retrieved a few moments later by the notifying modules?

@askmike
Copy link
Owner

askmike commented Jun 29, 2017

Yes! Exactly this is being worked in in #737. How it works is that the "roundtrips" visible in the UI (right now for backtesting and paper trading only) will hold information regarding the execution price.

Note that this requires quite a few changes (per exchange as well as through the codebase).

@askmike
Copy link
Owner

askmike commented Jun 29, 2017

I am closing this as it's functionality that is coming soon. But feel free to keep commenting.

@askmike askmike closed this as completed Jun 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants