Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify time validity only with --cert-verify=1 #32

Closed
wants to merge 1 commit into from

Conversation

hnimminh
Copy link

@hnimminh hnimminh commented Oct 11, 2024

Hi @miconda thank again for your useful stuff,

When I run below command to verify time validity:
secsipidx -check -fidentity libre.identity -fpubkey libre.cer -expire 1000000 -ca-file rootca.cer --crl-file crl --cert-verify 1

then output

error message: x509: “SHAKEN FRTE00” certificate is not trusted
not-ok

This error happen because of later validation

Since README document mention

  • 1 (1<<0) - verify time validity (not expired and not before validity date)

In my opinion, this error should not happen, cause user only want to verify time validity

So, I created simple pull request for correct it as document, could you please take time to review. Thanks.

@hnimminh hnimminh changed the title verify time validity only --cert-verify=1 verify time validity only with --cert-verify=1 Oct 11, 2024
@miconda
Copy link
Contributor

miconda commented Oct 14, 2024

The scope was to verify the certificate with or without checking the time validity, but I see what you aim at, might be useful in some cases. I will think about and see what is the best way to get it in. Thanks for the PR!

miconda added a commit that referenced this pull request Oct 18, 2024
@miconda
Copy link
Contributor

miconda commented Oct 18, 2024

I pushed a different commit with a new dedicated option (32) for time only verification.

@miconda miconda closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants