Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Fix sync validation errors #941

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

koplas
Copy link

@koplas koplas commented Sep 17, 2024

Simplify the fence usage to avoid errors with synchronization.

Closes #917

Simplify the fence usage to avoid errors with synchronization
@MarijnS95 MarijnS95 changed the title Fix sync validation errors examples: Fix sync validation errors Sep 20, 2024
@koplas
Copy link
Author

koplas commented Sep 23, 2024

I had to remove the fence wait in record_submit_commandbuffer.
While inspecting the code I found that calling record_submit_commandbuffer is not safe, as there is a plethora of things that are not checked that could violate that valid usage (See for example https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkQueueSubmit.html#_description).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: VALIDATION on examples
1 participant