Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move doxygen comments of public declarations from cpp to header files #846

Open
ypiguet-epfl opened this issue Mar 6, 2018 · 3 comments

Comments

@ypiguet-epfl
Copy link
Collaborator

At some places such as in aseba/compiler/compiler.cpp for method compile, the doxygen documentation of public methods is located in the cpp file. It would be better to put it in the header file (aseba/compiler/compiler.h), because the cpp file could be provided as compiled code and not readily available. That's already the case for some of the public declarations (e.g. struct SubroutineDescriptor).

@cor3ntin
Copy link
Contributor

cor3ntin commented Mar 6, 2018

Would you be willing to make a PR ?

@ypiguet-epfl
Copy link
Collaborator Author

I think the git/github work wouldn't be worth the trouble for someone like me whose PR are limited to minor code polish. This can wait.

@stephanemagnenat
Copy link
Member

For information, this was a design choice: at the time the compiler was written, code folding wasn't very widely available in editors and so the idea was that either someone knows more or less the code and wants to get a quick look at the available functions, and thus reads the h file, or this person wants the detailed information, and reads the generated documentation. This rationale might still be valid for people using editors such as vim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants