Fix Issue #56: Can't install latest version of npm globally

[andrewthauer]

Fix for issue #56

Note: This is based on the new feature in asdf (PR - asdf-vm/asdf#314)

The idea is to allow plugins to override the shim's specified executable path. In the case of npm the command may exist in one of 2 locations (bin/npm - by install or .npm/bin/npm - if upgraded manually).

[rstacruz]

LGTM... I like this fix. I think this is good to merge, @asdf-vm!

[adamyonk]

👋 I'm still seeing the bad functionality on asdf and asdf-nodejs latest versions. Is there anything else that needs to happen or am I missing something? Thanks!

❯ npm -v
5.6.0

❯ npm i -g npm
/Users/adamyonk/.asdf/installs/nodejs/8.9.4/.npm/bin/npx -> /Users/adamyonk/.asdf/installs/nodejs/8.9.4/.npm/lib/node_modules/npm/bin/npx-cli.js
/Users/adamyonk/.asdf/installs/nodejs/8.9.4/.npm/bin/npm -> /Users/adamyonk/.asdf/installs/nodejs/8.9.4/.npm/lib/node_modules/npm/bin/npm-cli.js
+ [email protected]
added 682 packages in 25.517s

❯ asdf reshim nodejs

❯ npm -v
5.6.0

[adamyonk]

Ah, interesting, I was on asdf 0.4.3, but asdf update --head seems to be ahead of that release and I can confirm it is working there!

[Stratus3D]

@adamyonk yes I need to tag a new version. Working on it now. Version 0.5.0 should be out within the next 3 hours.

[Stratus3D]

Out of curiosity, where does this .npm directory reside? I'm not very familiar with Node.JS.

[andrewthauer]

@Stratus3D - The .npm directory is actually not a standard directory in nodejs. In the context of asdf it comes from the usage of NPM_CONFIG_PREFIX override location used in exec-env. Another option to fix this issue could have been to remove the custom exec-env from asdf-nodejs that (which could still be done).