Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Antora resources IDs on images #614

Merged

Conversation

marieflorescontact
Copy link
Collaborator

this is WIP
I am not sure where to create the contentCatalog (I guess when the Antora support is activated?)

@marieflorescontact marieflorescontact force-pushed the antora-link-resolver branch 3 times, most recently from b17372f to b605323 Compare August 1, 2022 14:32
src/asciidocParser.ts Outdated Show resolved Hide resolved
@marieflorescontact marieflorescontact force-pushed the antora-link-resolver branch 3 times, most recently from d99dc51 to db97e30 Compare August 4, 2022 15:37
@marieflorescontact marieflorescontact force-pushed the antora-link-resolver branch 3 times, most recently from b314e37 to 84710c1 Compare August 23, 2022 14:14
@marieflorescontact marieflorescontact force-pushed the antora-link-resolver branch 2 times, most recently from 1be5db3 to d005696 Compare September 7, 2022 07:39
@marieflorescontact marieflorescontact force-pushed the antora-link-resolver branch 8 times, most recently from f26c039 to 359331f Compare September 8, 2022 16:15
@ggrossetie
Copy link
Member

Error: src/test/asciidoctorconfig.test.ts(55,108): error TS2345: Argument of type 'WebviewPanel' is not assignable to parameter of type 'WebviewResourceProvider'.
Type 'WebviewPanel' is missing the following properties from type 'WebviewResourceProvider': asWebviewUri, asMediaWebViewSrc, cspSource

src/test/asciidoctorconfig.test.ts is using the AsciidocParser so we need to update the call signature.

@marieflorescontact
Copy link
Collaborator Author

I use Sinon.JS as mock library to mock AntoraDocumentContext :

After many tries I didn't manage to test AsciidoctorWebViewConverter for an Antora ID.
ContentCatalog was always undefined and aggregateContent() sent me an error because the workspacefolder used while testing was not a git repository 😕

@ggrossetie ggrossetie changed the title Start to implement ids resolver Resolve Antora resources IDs on images Nov 15, 2022
@ggrossetie ggrossetie merged commit 7a8ca10 into asciidoctor:master Nov 15, 2022
@marieflorescontact marieflorescontact deleted the antora-link-resolver branch November 15, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants