Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background images should be resolved relative to imagesdir #17

Closed
mojavelinux opened this issue Mar 18, 2015 · 1 comment
Closed

Background images should be resolved relative to imagesdir #17

mojavelinux opened this issue Mar 18, 2015 · 1 comment
Assignees
@mojavelinux
Labels
🍩 improvement

Comments

@mojavelinux
Copy link
Member

To be consistent with how images are resolved in AsciiDoc, the background images (currently the data-background-image attribute on a section) should be resolved relative to the imagesdir directory. This matches the behavior of the image macros.

We should be careful to do this both for the data-background and data-background-image attributes, or we should drop the data-background attribute (since it potentially conflicts with other attributes).
@mojavelinux mojavelinux self-assigned this Mar 18, 2015
@obilodeau
Copy link
Member

This will be fixed by PR #52 which will get merged once reviewed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
🍩 improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mojavelinux @obilodeau