Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add INFO message to site modules showing the filename in case of issues #961

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Oct 28, 2024

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?

This PR uses the new 'reference' parameter in Doxia Parsers to print the source filename when an issue is detected. This is compatible and extends the features in 'logHandler'.

Fixes #323

Are there any alternative ways to implement this?

No

Are there any implications of this pull request? Anything a user must know?

No. In fact, the behavior is slightly different from process-asciidoc mojo to minimize changes.
See comment #323 (comment)

Is it related to an existing issue?

  • Yes...finally!
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

This PR uses the new 'reference' parameter in Doxia Parsers
to print the source filename when an issue is detected.
This is compatible and extends the features in 'logHandler'.

Fixes asciidoctor#323
@abelsromero abelsromero merged commit 138897c into asciidoctor:main Oct 28, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error/warning log handling
1 participant