(main) Fix resolution of baseDir in site-integration #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
branch-main/issue-968/fix-maven-site-includes-with-locales
branch
from
a134c8b to
8b1e904
Compare
Calculation now takes into consideration locale and siteDirectory correctly.
3 tasks
abelsromero
force-pushed
the
branch-main/issue-968/fix-maven-site-includes-with-locales
branch
from
1f332e7 to
eaa7d4b
Compare
abelsromero
force-pushed
the
branch-main/issue-968/fix-maven-site-includes-with-locales
branch
from
eaa7d4b to
507361f
Compare
abelsromero
changed the title
abelsromero
added a commit
that referenced
this pull request
Nov 2, 2024
* Resolution now takes into consideration locale and siteDirectory correctly. * Add a warning message when multiple locales are found Fixes #968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
The calculation now takes into consideration locale and siteDirectory correctly. All of this when user does not explicitly sets
baseDirin theAre there any alternative ways to implement this?
For better compatibility with older maven-site plugin we could have tried some reflection to "guess" the version, but this adds "IMO" unnecessary complexity. Users should be incentivized to upgrade.
Are there any implications of this pull request? Anything a user must know?
Users with older versions should upgrade or avoid using locales. As a workaround, multiple executions with siteDirectory can be configured.
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc
Fixes #968