Support Code blocks titles in asciidoctor-parser-doxia-module #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
branch-main/935/add-code-block-titles-to-parser-doxia-module
branch
from
b973c1b to
510e535
Compare
abelsromero
force-pushed
the
branch-main/935/add-code-block-titles-to-parser-doxia-module
branch
from
510e535 to
84c4897
Compare
abelsromero
force-pushed
the
branch-main/935/add-code-block-titles-to-parser-doxia-module
branch
from
84c4897 to
1b66f74
Compare
Adding non Doxia/fluido supported feature. For now we embed some styles. Fixes asciidoctor#935
abelsromero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Adding non Doxia/fluido supported feature.
Are there any alternative ways to implement this?
For now we embed some styles. When we add more "un-supported" features we'd need to create a fluid compatible extra CSS and look into how to inject it and how to define custom CSS classes without breaking Fluido Skin.
Are there any implications of this pull request? Anything a user must know?
This adds an AsciiDoc feature that is not supported natively by Doxia or Fluido skin
Is it related to an existing issue?
Fixes #935