Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Homebrew fomular #196

Open
hcoona opened this issue Sep 29, 2018 · 11 comments
Open

Add Homebrew fomular #196

hcoona opened this issue Sep 29, 2018 · 11 comments

Comments

@hcoona
Copy link

hcoona commented Sep 29, 2018

I'd like to have asciidoctor-diagram in Homebrew fomular just like asciidoctor

@mojavelinux
Copy link
Member

I support this idea. It could really simplify installation. Would you be willing to contribute the formula (or at least get started)?

@hcoona
Copy link
Author

hcoona commented Sep 29, 2018

I tried by modify asciidoctor fomular but failed to get it work. We need somebody familiar with the Homebrew gem mechanism.

https://gist.github.com/hcoona/e24394c3501e70513fcc57860b980f3a

There is a major issue: the asciidoctor cannot found asciidoctor-diagram gem.

There is a minor issue: the asciidoctor-diagram also build asciidoctor gem although I installed it by brew install asciidoctor. As a result, there are 2 asciidoctor commands provided by asciidoctor homebrew fomular & asciidoctor-diagram fomular. (The major issue occurs for either case)

@mojavelinux
Copy link
Member

Can you be more specific about what didn't work?

@eddiejaoude
Copy link
Contributor

Was there any progress on this issue? Having installed Asciidoctor via brew, it would be great to be able to install the diagram extension the same way.

@pepijnve
Copy link
Member

This is not something I'm working on myself. It's not clear to me what the added value is of brew install asciidoctor-diagram over gem install asciidoctor-diagram to be honest.

@eddiejaoude
Copy link
Contributor

The reason why I want to install it via brew instead of gem, is for 2 reasons:

  1. I installed asciidoctor via brew
  2. In my dotfiles repo, I have a brew file with a list of items, but I do not have or use a gem file, so I would need to add it to my config just for the 1 item

@pepijnve
Copy link
Member

Maybe something like https://github.com/sportngin/brew-gem could help there?

@eddiejaoude
Copy link
Contributor

Oh nice, thank you 👍

@ascheman
Copy link

ascheman commented Jun 3, 2021

The problem here is that AsciiDoctor on Homebrew comes with a starter script which explicitly specifies a GEM_HOME:

$ less /usr/local/bin/asciidoctor
#!/bin/bash
GEM_HOME="/usr/local/Cellar/asciidoctor/2.0.15/libexec" exec "/usr/local/Cellar/asciidoctor/2.0.15/libexec/bin/asciidoctor"  "$@"

If you need the asciidoctor-diagram plugin, you need to install that to the version specific GEM_HOME directory. And you need to do that with any update of asciidoctor. I do have a cron Job on my MacBook which performs a nightly update of all formulas. Therefor it would be great if there was a asciidoctor-diagram formula which would then update the diagram feature as well.

@johnnyutahh
Copy link

Checking in: has there been any further thoughts, movement, motivation for this?

@pepijnve
Copy link
Member

pepijnve commented Apr 6, 2023

@johnnyutahh nothing from my side and no plans either. Pull requests, If necessary, are welcome of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants