Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditaa options do not work #371

Closed
coschtl opened this issue Aug 7, 2018 · 10 comments
Closed

Ditaa options do not work #371

coschtl opened this issue Aug 7, 2018 · 10 comments

Comments

@coschtl
Copy link

coschtl commented Aug 7, 2018

Hi,
I tried to use the dita-options, but it seems that they are ignored (version 1.6.3). The following lines should render a pink rectangle directly inside a blue one (see:) but they get separated:

[ditaa, options='no-separation']

+---------+
| cBLU |
| |
| +----+
| |cPNK|
| | |
+----+----+

@coschtl
Copy link
Author

coschtl commented Aug 7, 2018

Sorry, I forgot to add the pre-Tags:

[ditaa, options='no-separation']
--
+---------+
| cBLU    |
|         |
|    +----+
|    |cPNK|
|    |    |
+----+----+
--

@rahmanusta
Copy link
Member

Thanks for reporting. Let me check it

@rahmanusta
Copy link
Member

Where [ditaa, options='no-separation'] is supported? I didn't see it asciidoctor-diagram.

@coschtl
Copy link
Author

coschtl commented Aug 8, 2018

Seems to be an outdated version of setting the options. But also the new syntax described at asciidoctor/asciidoctor-diagram#69 (comment) doesn't seem to work in ascidocfx.
Shouldn't this work here also?

@rahmanusta
Copy link
Member

This can be implemented. I just were not aware of it.

@coschtl
Copy link
Author

coschtl commented Aug 8, 2018

Cool. Thank you very much!

@rahmanusta
Copy link
Member

rahmanusta commented Aug 9, 2018

Feature has been implemented. Please check the latest version. It support both old and new style ditaa options.

@rahmanusta
Copy link
Member

image

@coschtl
Copy link
Author

coschtl commented Aug 10, 2018

Works like a charm!
Thanks for implementing that so fast.

@coschtl coschtl closed this as completed Aug 10, 2018
@rahmanusta
Copy link
Member

You are welcome. Thanks for reporting ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants