Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Preview #289

Open
Kamrulhasan12345 opened this issue Apr 11, 2024 · 5 comments
Open

Card Preview #289

Kamrulhasan12345 opened this issue Apr 11, 2024 · 5 comments

Comments

@Kamrulhasan12345
Copy link

Currently, hovering on items don't show card previews if this feature is enabled in about:config.

@asamuzaK
Copy link
Owner

@asamuzaK
Copy link
Owner

Ref tabs.captureTab() - Mozilla | MDN

You must have the <all_urls> permission to use this method.

@asamuzaK
Copy link
Owner

Ref 1784920 - Add activeTab as permission for tabs.captureVisibleTab API

Target Milestone: --- → 126 Branch

Milestones and key data for Firefox 126

Release Date May 14, 2024

@asamuzaK
Copy link
Owner

asamuzaK commented Apr 13, 2024

Some notes:

  • Behavior
    • The preview image is the thumbnail of the initial display, not the thumbnail of actual displayed area. Bug 1879089
    • Does not preview active tab.
    • Does not preview discarded tab either.
    • Does not preview during drag and drop.
  • Layout
    • Top row is the title, middle row is domain (without scheme) Bug 1879345, bottom row is preview image.
      • domain not shown on about: schemes.
    • Must be displayed in the sidebar so width of the preview will be very limited.
      • The image will be considerably reduced.
      • For example, if the tab is in the top half of the viewport (<50vh), display below the tab, and vice versa for the tabs in the bottom half?
    • For rtl sites, maybe it needs to clip image from right, e.g. object-fit: cover; object-position: 100% 0;
      ATM, image is clipped from top left. Bug 1877837
  • Options page
    • At least for now, the value of browser.tabs.cardPreview.enabled cannot be retrieved from browserSettings, so it needs to be set from an options page.
    • For browsers below 126.0, require optional permission <all_urls>.
      • activeTab is required by default.

It may be possible to implement, but the performance cost is likely to be quite high.

@asamuzaK
Copy link
Owner

asamuzaK commented Apr 19, 2024

Ref:

It seems that it is still in the early stages of implementation and is still under development.
Let's wait and see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants