-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated mousetrap reference #509
Conversation
…p by kloudi-tech where useCapture has been exposed with a default value of true.
Thanks but I noticed this change updates to a fork of mousetrap. Can you open a PR to support this change with mousetrap upstream? |
Code Climate has analyzed commit f525b38 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
@asabaylus There has been PR in mousetrap that is open since 2017 for this change. It doesn't seem like it will get merge. Hence I started maintaining a separate folk. |
@kloudi-tech thanks I’ll give him a few days to reply to my comment on the PR ccampbell/mousetrap#400 (comment) If no response are you planning to maintain mousetrap? Possibly Craig would like someone to maintain |
I'll be maintaining the folk that we have at @kloudi-tech (https://github.com/kloudi-tech/mousetrap) Majorly making sure that the upstreams doesn't have any conflict with the changes that we have made around useCapture event. |
@nitishMehrotra please reach out to @ccampbell about taking on long term maintenance of mousetrap.js. It seems like the repo has fallen out of maintenance, he may be ready to turn it over. I don't think introducing a dependency on a forked repo is good long term idea as NPM exists for some very good reasons |
Updated mousetrap reference with a publically hosted folk of mousetrap by kloudi-tech where useCapture has been exposed with a default value of true.
This should close Issue #455