Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
align="left"
we used as default in matplotlib distplot is great for ints, but super confusingfor floats (which are also valid histogram input via
kind
kwarg and/or rcparam). The plotbelow shows the issue:
bokeh distplot used a mid/centered bins approach which is great for floats, but
requires remembering that intervals are [left_edge, right_edge) for ints. Now both
should behave in the same way, in both cases plotting histograms adapted to the dtype
of the input.
Checklist
📚 Documentation preview 📚: https://arviz--2247.org.readthedocs.build/en/2247/