Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added facade functions to_zarr and from_zarr #2236

Merged
merged 6 commits into from
Jul 11, 2023

Conversation

pSpitzner
Copy link
Contributor

@pSpitzner pSpitzner commented Apr 13, 2023

Description

This adds to_zarr and from_zarr on the module level.

Before, prefixing by InferenceData was needed, now both of the following should work

import arviz as az
idata = az.InferenceData.from_zarr(my_store)
idata = az.from_zarr(my_store)

Checklist

  • Follows official PR format
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2236.org.readthedocs.build/en/2236/

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have added a couple comments, sorry I missed the PR

CHANGELOG.md Outdated Show resolved Hide resolved
arviz/tests/base_tests/test_data_zarr.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #2236 (c7f2227) into main (37540cd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2236   +/-   ##
=======================================
  Coverage   87.89%   87.90%           
=======================================
  Files         121      122    +1     
  Lines       12448    12458   +10     
=======================================
+ Hits        10941    10951   +10     
  Misses       1507     1507           
Impacted Files Coverage Δ
arviz/data/__init__.py 100.00% <100.00%> (ø)
arviz/data/io_zarr.py 100.00% <100.00%> (ø)

@OriolAbril OriolAbril merged commit 8632186 into arviz-devs:main Jul 11, 2023
@pSpitzner
Copy link
Contributor Author

Hi @OriolAbril,

thanks for putting in the fixes and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants