Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding plotting guides #2025

Merged
merged 15 commits into from
May 6, 2022
Merged

Adding plotting guides #2025

merged 15 commits into from
May 6, 2022

Conversation

symeneses
Copy link
Contributor

Description

Adds plotting guide per backend. It solves #1488

Checklist

OriolAbril
OriolAbril reviewed May 1, 2022
View reviewed changes
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far, thanks! I'll continue reviewing as soon as possible

doc/source/user_guide/plotting_with_bokeh.md Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Outdated Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Outdated Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Outdated Show resolved Hide resolved
OriolAbril
OriolAbril reviewed May 3, 2022
View reviewed changes
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, reviewed already stylistic choices and typos

doc/source/user_guide/plotting_with_bokeh.md Outdated Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Outdated Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Outdated Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Outdated Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Show resolved Hide resolved
doc/source/user_guide/plotting_with_bokeh.md Show resolved Hide resolved
doc/source/user_guide/plotting_with_matplotlib.md Outdated Show resolved Hide resolved
doc/source/user_guide/plotting_with_matplotlib.md Outdated Show resolved Hide resolved
@symeneses
Copy link
Contributor Author

Everything looks great, reviewed already stylistic choices and typos

Looks like all the conversations are solved now.

@OriolAbril OriolAbril merged commit 4364014 into arviz-devs:main May 6, 2022
@OriolAbril
Copy link
Member

Thanks!

@symeneses symeneses deleted the doc/plotting-guides branch May 9, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OriolAbril OriolAbril OriolAbril left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@symeneses @OriolAbril