Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labels and use circular KDE in plot_trace #1428

Merged
merged 4 commits into from
Oct 23, 2020
Merged

Fix labels and use circular KDE in plot_trace #1428

merged 4 commits into from
Oct 23, 2020

Conversation

agustinaarroyuelo
Copy link
Contributor

@agustinaarroyuelo agustinaarroyuelo commented Oct 20, 2020

Description

I noticed that the KDE plot in plot_trace was not using the circular KDE function (#1284). I also fixed the labels so that both columns share the same units.

Degrees:

traceplot_circ_degrees

Radians:

traceplot_circ_radians

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #1428 into master will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   91.58%   91.94%   +0.35%     
==========================================
  Files         105      105              
  Lines       11125    11132       +7     
==========================================
+ Hits        10189    10235      +46     
+ Misses        936      897      -39     
Impacted Files Coverage Δ
arviz/plots/backends/matplotlib/kdeplot.py 98.75% <ø> (ø)
arviz/plots/backends/matplotlib/traceplot.py 98.80% <100.00%> (+0.05%) ⬆️
arviz/plots/kdeplot.py 100.00% <0.00%> (+3.12%) ⬆️
arviz/stats/density_utils.py 75.07% <0.00%> (+10.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e50848...d20bc24. Read the comment docs.

@aloctavodia aloctavodia merged commit 475e34c into arviz-devs:master Oct 23, 2020
@agustinaarroyuelo agustinaarroyuelo deleted the traceplot_circ_kde branch October 29, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants