Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_rank change axes to ax, fix plot_trace ax #1144

Merged
merged 4 commits into from
Apr 13, 2020
Merged

plot_rank change axes to ax, fix plot_trace ax #1144

merged 4 commits into from
Apr 13, 2020

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Apr 9, 2020

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #1144 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
- Coverage   92.82%   92.81%   -0.01%     
==========================================
  Files          94       93       -1     
  Lines        9193     9182      -11     
==========================================
- Hits         8533     8522      -11     
  Misses        660      660              
Impacted Files Coverage Δ
arviz/plots/backends/bokeh/traceplot.py 95.97% <100.00%> (ø)
arviz/plots/backends/matplotlib/traceplot.py 99.15% <100.00%> (ø)
arviz/plots/rankplot.py 91.66% <100.00%> (-0.23%) ⬇️
arviz/utils.py 90.00% <0.00%> (-1.03%) ⬇️
arviz/plots/distplot.py 93.54% <0.00%> (-0.21%) ⬇️
arviz/plots/backends/matplotlib/densityplot.py 96.36% <0.00%> (-0.07%) ⬇️
arviz/plots/backends/bokeh/posteriorplot.py 98.07% <0.00%> (-0.02%) ⬇️
arviz/plots/backends/matplotlib/posteriorplot.py 98.07% <0.00%> (-0.02%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d11040...7df21d5. Read the comment docs.

CHANGELOG.md Outdated
### Maintenance and fixes
* Fixed behaviour of `credible_interval=None` in `plot_posterior` (#1115)
* Fixed hist kind of `plot_dist` with multidimensional input (#1115)
* Fixed `TypeError` in `transform` argument of `plot_density` and `plot_forest` when `InferenceData` is a list or tuple (#1121)
* Fixed overlaid pairplots issue (#1135)
* Update Docker building steps (#1127)
* Rank plot: rename `axes` arguemt to `ax` (#1144)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argument

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@aloctavodia aloctavodia merged commit 04388c2 into master Apr 13, 2020
@aloctavodia aloctavodia deleted the rt_axes branch April 13, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants