-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix credible_interval=None and plot_dist with ndim>2 #1115
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fd2edb2
Resolved issue occuring in processing a Dataarray with dimension grea…
smit-s fd91b7c
Corrected the spaces and tabs
smit-s 7438469
addressed review comments
smit-s 1a40822
Resolved pylint corrections
smit-s 1373974
review comments addressed
smit-s 58f0a23
pylint check failure
smit-s 2a229f3
not added earlier
smit-s 1fdc11b
updated CHANGELOG.md
smit-s ac2fb93
Improved
smit-s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,11 @@ | ||
"""Matplotlib distplot.""" | ||
import warnings | ||
import matplotlib.pyplot as plt | ||
|
||
import numpy as np | ||
from . import backend_show | ||
from ...kdeplot import plot_kde | ||
from ...plot_utils import matplotlib_kwarg_dealiaser | ||
from ...plot_utils import get_bins | ||
|
||
|
||
def plot_dist( | ||
|
@@ -91,8 +92,10 @@ def _histplot_mpl_op(values, values2, rotated, ax, hist_kwargs): | |
raise NotImplementedError("Insert hexbin plot here") | ||
|
||
bins = hist_kwargs.pop("bins") | ||
OriolAbril marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if bins is None: | ||
bins = get_bins(values) | ||
ax.hist(np.asarray(values).flatten(), bins=bins, **hist_kwargs) | ||
OriolAbril marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above |
||
|
||
ax.hist(values, bins=bins, **hist_kwargs) | ||
if rotated: | ||
ax.set_yticks(bins[:-1]) | ||
else: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should move this before using values for bins and do
values = np.asarray(values).flatten()
to use always flattened array.