Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure interpolation for plot_hpd always works #1039

Merged
merged 2 commits into from
Feb 4, 2020
Merged

ensure interpolation for plot_hpd always works #1039

merged 2 commits into from
Feb 4, 2020

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Jan 30, 2020 •
edited by OriolAbril
Loading

plot_hpd performs a linear interpolation before smoothing a hpd interval. This fix ensures that the points were the interpolation is evaluated are "inside" the data.

  • Does the PR follow official PR format?
  • Has included a sample plot to visually illustrate the changes? (only for plot-related functions)
  • Is the code style correct (follows pylint and black guidelines)?
  • Is the change listed in changelog?

Before
old

after
new

@OriolAbril
Copy link
Member

LGTM

@aloctavodia aloctavodia merged commit 034dd14 into master Feb 4, 2020
@aloctavodia aloctavodia deleted the hpd_eps branch February 4, 2020 11:46
@aloctavodia aloctavodia mentioned this pull request Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OriolAbril OriolAbril OriolAbril approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aloctavodia @OriolAbril