Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transform argument to plots #1036

Merged
merged 17 commits into from
Feb 6, 2020
Merged

Add transform argument to plots #1036

Changes from 9 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
218a7ef
fixing 843
amukh18 Jan 15, 2020
6f380df
fix 843 docstring
amukh18 Jan 15, 2020
040a270
fix 843-
amukh18 Jan 15, 2020
da2c817
Update ppcplot.py
amukh18 Jan 17, 2020
8e9fe87
Removed whitespace
amukh18 Jan 18, 2020
91163f0
Removed trailing whitespaces
amukh18 Jan 19, 2020
0a13076
Merge branch 'master' into feature1
amukh18 Jan 21, 2020
770e8fa
add transform argument
amukh18 Jan 29, 2020
382cc39
Merge branch 'master' into transform
amukh18 Jan 29, 2020
1f5b1fe
Fixed elementary Python error, added arg to other functions
amukh18 Feb 4, 2020
6aa2d59
Merge branch 'transform' of github.com:amukh18/arviz into transform
amukh18 Feb 4, 2020
f8645de
Fixed indentation and removed stray lines
amukh18 Feb 4, 2020
d877ca4
Replaced tab with spaces
amukh18 Feb 5, 2020
606e091
Reformatted with black
amukh18 Feb 5, 2020
72bdd9c
updated changelog
amukh18 Feb 5, 2020
fdb20d6
modified spacing in changelog
amukh18 Feb 5, 2020
fbbac6b
Merge branch 'master' into transform
amukh18 Feb 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions arviz/plots/traceplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ def plot_trace(
var_names=None,
coords=None,
divergences="bottom",
transform=None,
figsize=None,
rug=False,
lines=None,
Expand Down Expand Up @@ -46,6 +47,8 @@ def plot_trace(
Coordinates of var_names to be plotted. Passed to `Dataset.sel`
divergences : {"bottom", "top", None, False}
Plot location of divergences on the traceplots. Options are "bottom", "top", or False-y.
transform : callable
Function to transform data (defaults to identity)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better wording will be "Function to transform data (defaults to None i.e. the identity function)" or probably just "Function to transform data (defaults to None)"

figsize : figure size tuple
If None, size is (12, variables * 2)
rug : bool
Expand Down Expand Up @@ -137,6 +140,9 @@ def plot_trace(
divergence_data = False

data = get_coords(convert_to_dataset(data, group="posterior"), coords)

data = transform(data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By doing this you are basically writing data = None(data), which is not legal Python. Instead you should do something like:

if transform is not None:
    data = transform(data)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aloctavodia Sorry for this elementary mistake! I fixed it.


var_names = _var_names(var_names, data)

if lines is None:
Expand Down