Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving converters to other packages #239

Open
sethaxen opened this issue Oct 28, 2022 · 2 comments
Open

Moving converters to other packages #239

sethaxen opened this issue Oct 28, 2022 · 2 comments
Assignees

Comments

@sethaxen
Copy link
Member

Recently I've heard a number of reports from users that issues with Python dependencies or their installation prevent them from using ArviZ.jl (see e.g. #206). Some of these users ask if they can just use InferenceObjects.jl with Turing.jl. Since all of our converters here are pure Julia, we should prioritize moving them out of this package into either a glue package (e.g. SampleChainsInferenceObjects.jl) or directly into the package where the input to the converter is defined (as has been proposed with MCMCChains, see TuringLang/MCMCChains.jl#381).

While such users would still not be able to use our functionality that forwards to Python, they could still get the benefits of working with InferenceData, dimensional arrays, and the Tables interface.

@sethaxen sethaxen self-assigned this Oct 29, 2022
@sethaxen
Copy link
Member Author

sethaxen commented Nov 4, 2022

See also StanJulia/StanSample.jl#60 for discussions on letting StanSample implement its own converter. We could then deprecate the from_cmdstan converter and point users to that.

@sethaxen
Copy link
Member Author

sethaxen commented Nov 4, 2022

@cscherrer it likewise would be nice to move the conversion to InferenceData from SampleChains out of this package. This could either live in SampleChains/SampleChainsDynamicHMC via (conditional) dependence or in a glue package that users would need to import. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant