Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Band "end" computations #18

Open
JustKshitijD opened this issue Mar 4, 2024 · 0 comments
Open

Band "end" computations #18

JustKshitijD opened this issue Mar 4, 2024 · 0 comments

Comments

@JustKshitijD
Copy link

In line "beg = 0, end = qlen", I think "end" should be initialized as "end=w+1".
Also, "end=min(end,i+w+1)" should be replaced with "end=max(end,i+w+1)".

For ex- While aligning (CATT,ACT), using w=1, if the original code is used, then as "end=min(end,i+w+1)" will always keep "end=w+1=1" across all iterations i. Thus, the end of the band is never extended.

The above corrections on the other hand, fill the cells that are required for aligning the 2 strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant