Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Iban for Egypt (EG) #88

Closed
NaveenKumarRajulapati opened this issue Oct 19, 2021 · 5 comments
Closed

Adding Iban for Egypt (EG) #88

NaveenKumarRajulapati opened this issue Oct 19, 2021 · 5 comments

Comments

@NaveenKumarRajulapati
Copy link

Currently Egypt is using IBAN and we don't have defined that in CountryCode. Because of that we are getting org.iban4j.UnsupportedCountryException: Country code is not supported.

Can we just add Egypt code in the CountryCode class.

@FrankHossfeld
Copy link

There is already a PR:

#85

@NaveenKumarRajulapati
Copy link
Author

Thanks @FrankHossfeld.

Do we have any ETA when we will be merging this.

@FrankHossfeld
Copy link

FrankHossfeld commented Oct 19, 2021

Sorry, no idea. I am not a contributor of this lib.

I have cloned the lib and added/changed a few things and fixed a few bugs. At least I need to change some things to use the lib with GWT/J2CL. Nothing that should have an impact of the way how to use it with Java.

The clone has the same API. And as far as I remember, the IBAN definition of EG is already added.

If you like, you can give it a try: https://github.com/NaluKit/iban4g

@NaveenKumarRajulapati
Copy link
Author

Thanks @FrankHossfeld for your support. Let me check it.

@bogacaslan
Copy link
Contributor

I created another PR for this issue, including only required changes:

#103

@hajk1 hajk1 closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants