Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracing] Make it possible to detect resolvers that perform longer running work #829

Open
alloy opened this issue Nov 22, 2017 · 4 comments

Comments

@alloy
Copy link
Contributor

alloy commented Nov 22, 2017

We should make these resolvers use async/await, because then these functions will be instances of AsyncFunction and we can filter resolvers to wrap by checking for that class instead.

@alloy
Copy link
Contributor Author

alloy commented Nov 22, 2017

I’m thinking that we can maybe use the TS compiler to automatically rewrite all resolvers that return promises, as long as they come from the data loaders.

@orta
Copy link
Contributor

orta commented Nov 22, 2017

*babel

@alloy
Copy link
Contributor Author

alloy commented Nov 22, 2017

No not babel, because the TS support in Babel really only means that it can parse TS code, it doesn’t do anything with the types such as inference, which is probably what we’d need.

@orta
Copy link
Contributor

orta commented Nov 28, 2017

yep, that's smart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants