This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Updates README #1823
Merged
Updates README #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloy
reviewed
Aug 30, 2019
alloy
reviewed
Sep 6, 2019
README.md
Outdated
| @@ -96,12 +96,13 @@ We vendor some data from other repositories that you will sometimes need to upda | |||
|
|
|||
| **Note:** Deploys are mostly automated using `yarn release patch|minor|major`; the following instructions should be valid but take a look at [this issue](https://github.com/artsy/emission/issues/1077#issuecomment-401128949) if things break. | |||
|
|
|||
| **Note 2:** If you're updating React Native, you're gonna have to do a lot of this stuff manually. See the makefile/alloy/orta for more info. | |||
| **Note 2:** If you're updating React Native, you're going to have to do a lot of this stuff manually. See the makefile or alloy for more info. | |||
There was a problem hiding this comment.
Suggested change
| **Note 2:** If you're updating React Native, you're going to have to do a lot of this stuff manually. See the makefile or alloy for more info. | |
| **Note 2:** If you're updating React Native, you're going to have to do a lot of this stuff manually. See the makefile, ashfurrow, or alloy for more info. |
There was a problem hiding this comment.
Ash aint getting off that easy.
alloy
reviewed
Sep 6, 2019
README.md
Outdated
| 2. For non-pre-releases, use either `yarn release patch`, `yarn release minor`, or `yarn release major`. For | ||
| pre-releases, use `yarn release prerelease`. Pre-releases are usually reserved for testing major releases before deployment. | ||
| 3. After the release has finished compiling, a PR will be automatically created in Metaphysics, which can be self assigned and merged. | ||
| 4. If integrating in Eigen consult the docs [on updating Emission](https://github.com/artsy/eigen/blob/master/docs/updating_emission.md) |
There was a problem hiding this comment.
FYI If you only use 1. then when markdown gets rendered it automatically increases the number, which means you can move items around in the list without having to change numbers the whole time.
There was a problem hiding this comment.
Oh wow, didn't know, awesome.
alloy
reviewed
Sep 6, 2019
README.md
Outdated
| 1. If integrating in Eigen consult the docs [on updating Emission](https://github.com/artsy/eigen/blob/master/docs/updating_emission.md) | ||
| 2. For non-pre-releases, use either `yarn release patch`, `yarn release minor`, or `yarn release major`. For | ||
| pre-releases, use `yarn release prerelease`. Pre-releases are usually reserved for testing major releases before deployment. | ||
| 3. After the release has finished compiling, a PR will be automatically created in Metaphysics, which can be self assigned and merged. |
There was a problem hiding this comment.
Maybe add some detail about what the PR contains.
alloy
reviewed
Sep 6, 2019
| @@ -96,11 +96,12 @@ We vendor some data from other repositories that you will sometimes need to upda | |||
|
|
|||
| **Note:** Deploys are mostly automated using `yarn release patch|minor|major`; the following instructions should be valid but take a look at [this issue](https://github.com/artsy/emission/issues/1077#issuecomment-401128949) if things break. | |||
|
|
|||
| **Note 2:** If you're updating React Native, you're gonna have to do a lot of this stuff manually. See the makefile/alloy/orta for more info. | |||
| **Note 2:** If you're updating React Native, you're going to have to do a lot of this stuff manually. See the makefile, ashfurrow or alloy for more info. | |||
There was a problem hiding this comment.
I'm a minimalist at heart
|
Great, thanks! 🚀 #MergeOnGreen |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#trivial