feat(publish-metrics): implement multiple otel improvements #2779
+17
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multiple changes in OTel:
url
attribute is added to page spans in Playwright tracingfix for bug in Playwright tracing support - using
url
attribute instead ofname
is used along withvu.uuid
to match web vitals with appropriatepageSpan
(replaceSpanNameRegex
introduced a bug where web vitals would not appear for spans with replaced names)remove
test_id
being added by default to OTel metricsRequest timing phases are recorded as attributes instead of spans in HTTP tracing for the purpose of reducing the cost. (e.g.
dns_lookup
span is nowdns_lookup.duration
attribute with a value inms
set on the request span it belongs to.)Testing
Tested manually, and will be added to OTel tracing tests in #2718
dd-adot.test
that runs http test is adjusted to reflect the change in trace structure.Pre-merge checklist