Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish-metrics): implement multiple otel improvements #2779

Merged
merged 5 commits into from
May 27, 2024

Conversation

InesNi
Copy link
Contributor

@InesNi InesNi commented May 22, 2024

Description

Multiple changes in OTel:

  1. url attribute is added to page spans in Playwright tracing

  2. fix for bug in Playwright tracing support - using url attribute instead of name is used along with vu.uuid to match web vitals with appropriate pageSpan (replaceSpanNameRegex introduced a bug where web vitals would not appear for spans with replaced names)

  3. remove test_id being added by default to OTel metrics

  4. Request timing phases are recorded as attributes instead of spans in HTTP tracing for the purpose of reducing the cost. (e.g. dns_lookup span is now dns_lookup.duration attribute with a value in ms set on the request span it belongs to.)

    • !This will change the structure of traces for HTTP engine support

Testing

Tested manually, and will be added to OTel tracing tests in #2718

  • Due to 4. changing the structure of tests the dd-adot.test that runs http test is adjusted to reflect the change in trace structure.

Pre-merge checklist

  • Does this require an update to the docs?
  • Does this require a changelog entry?

@InesNi InesNi changed the title Otel small improvements feat(publish-metrics): Otel small improvements May 22, 2024
@InesNi InesNi changed the title feat(publish-metrics): Otel small improvements feat(publish-metrics): implement multiple small otel improvements May 22, 2024
@InesNi InesNi changed the title feat(publish-metrics): implement multiple small otel improvements feat(publish-metrics): implement multiple otel improvements May 24, 2024
@hassy
Copy link
Member

hassy commented May 27, 2024

Test failure unrelated, merging.

@hassy hassy merged commit 391fcd6 into main May 27, 2024
27 of 28 checks passed
@hassy hassy deleted the otel-small-improvements branch May 27, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants