fix(core): import mjs path correctly when running on windows

[thrandale]

This fixes issue #2661

[CLAassistant]

All committers have signed the CLA.

[hassy]

thanks @thrandale! Is the issue due to a missing relative path? ie. in your example ./artilleryRunner.mjs should work as expected (if the MJS file is in the same directory as the YAML script). There's a test for loading ESM here, would you mind updating that please? https://github.com/artilleryio/artillery/blob/242a7964934851bf77e53eebf44e6312de723663/packages/artillery/test/cli/async-hooks-esm.test.js

[thrandale]

@hassy Even using a relative path, it still fails with the same error. When it does the path.resolve(), that resolve either an absolute or relative path to an absolute path. It is odd that it is not failing in the CI. I believe this is only an issue on Windows. Does the CI run the windows tests?

[ggecy]

@hassy Even using a relative path, it still fails with the same error. When it does the path.resolve(), that resolve either an absolute or relative path to an absolute path. It is odd that it is not failing in the CI. I believe this is only an issue on Windows. Does the CI run the windows tests?

I can confirm this - we have this problem only on windows, I can run it on macos without error. This is making the artillery completely unusable on windows if we have typescript configured to compile playwright tests to esm modules.

[bernardobridge]

Hi @thrandale 👋 ! Thanks for the contribution. We have now added windows tests to CI, so we could confirm fixes like this.

I've opened #3293 with your fix and ran our full suite against it, and it seems to work 👍 . If you want to rebase this branch with main (as it contains the windows tests), I can close my PR and merge this one once the test suite runs here too. If you do that in the next couple of days (as we aim to release on Monday), I'll use your PR. Otherwise I'll use my PR and reference you in the release anyway.

Thanks again!

[thrandale]

Thanks @bernardobridge. I have rebased my branch off main.

[bernardobridge]

Hi @thrandale, thanks for that. I'm merging this as the tests as passing (they appear red, but it's a bug that happens when running against contributor PR's).

Thanks again for the fix! It'll be out in 2.0.19 next week.