Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac artifacts are not code signed #18

Closed
lopopolo opened this issue Jan 2, 2021 · 7 comments · Fixed by #88
Closed

Mac artifacts are not code signed #18

lopopolo opened this issue Jan 2, 2021 · 7 comments · Fixed by #88
Labels
A-codesigning Area: Code signing, GPG signatures. A-release Area: Nightly releases and version bumps. A-security Area: Security vulnerabilities and unsoundness issues. A-target Area: nightly build support for various target triples. E-help-wanted Call for participation: Help is requested to fix this issue. T-aarch64-apple-darwin Target: ARM64 macOS (11.0+, Big Sur+) T-x86_64-apple-darwin Target: 64-bit macOS (10.7+, Lion+)

Comments

@lopopolo
Copy link
Member

lopopolo commented Jan 2, 2021

Reported on Twitter via https://twitter.com/jim_healy/status/1345505318709592064 and https://twitter.com/jim_healy/status/1345509713715187713.

Gatekeeper blocks airb and artichoke from launching because they are not signed by "an identified developer".

Eqw1tN-VQAE7N9d

Eqw1tOVVoAAeUPd

This looks like the right place to start:

@lopopolo lopopolo added A-security Area: Security vulnerabilities and unsoundness issues. A-target Area: nightly build support for various target triples. T-aarch64-apple-darwin Target: ARM64 macOS (11.0+, Big Sur+) T-x86_64-apple-darwin Target: 64-bit macOS (10.7+, Lion+) labels Jan 2, 2021
@lopopolo lopopolo added the E-help-wanted Call for participation: Help is requested to fix this issue. label Jan 3, 2021
@lopopolo
Copy link
Member Author

lopopolo commented Jan 3, 2021

#20 adds GPG signatures to nightly artifacts.

@lopopolo lopopolo added the A-release Area: Nightly releases and version bumps. label Jan 10, 2021
@lopopolo lopopolo added the A-codesigning Area: Code signing, GPG signatures. label Jul 14, 2021
@lopopolo
Copy link
Member Author

lopopolo commented Sep 7, 2021

There's a lot of good investigation here: simonw/datasette#1171

@lopopolo
Copy link
Member Author

lopopolo commented Sep 7, 2021

It looks like nightly artifacts need to be code signed and notarized.

I also found this article useful: https://localazy.com/blog/how-to-automatically-sign-macos-apps-using-github-actions

@lopopolo
Copy link
Member Author

The tools involved here are:

  • codesign
  • altool for notarizing and stapling.

@lopopolo
Copy link
Member Author

I was chatting with some folks on what steps I'd need to go through to get a Apple Developer Certificate for the code signing.

Transcript

lopopolo: If I want to get a code signing certificate for a project / GitHub organization, do I sign up for an Apple Developer account with my personal Apple ID? Or should I create a new developer account with an email alias for the project? There is no legal entity associated with the organization. I use a codesign[@]domain[.]tld email for the GPG keys that generate signatures for release artifacts.

[redacted]: I'd create a new Apple ID solely for developer. That way you don't have to change the email if someone else in the org wants to run signing for a while. Note that it really is an individual account associated with your real name. Also expect lots of spam to that email.

lopopolo: ok so maybe apple-codesign@domain[.]tld mapped to a google group that doesn't show up in my inbox. but the user on that apple ID would still be Ryan Lopopolo.

[redacted]: 👍

@lopopolo
Copy link
Member Author

I signed up for a new Apple ID and the Apple Developer Program today. Waiting for the account to get approved.

@lopopolo
Copy link
Member Author

Account was approved today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codesigning Area: Code signing, GPG signatures. A-release Area: Nightly releases and version bumps. A-security Area: Security vulnerabilities and unsoundness issues. A-target Area: nightly build support for various target triples. E-help-wanted Call for participation: Help is requested to fix this issue. T-aarch64-apple-darwin Target: ARM64 macOS (11.0+, Big Sur+) T-x86_64-apple-darwin Target: 64-bit macOS (10.7+, Lion+)
Development

Successfully merging a pull request may close this issue.

1 participant