You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your request related to a problem? Please describe.
After upgrading google.golang.org/grpc from v1.63.2 to v1.65.0, a couple of deprecation warnings are being reported by golangci-lint:
internal/telemetry/traces.go:36:15: SA1019: grpc.DialContext is deprecated: use NewClient instead. Will be supported throughout 1.x. (staticcheck)
conn, err := grpc.DialContext(
^
internal/telemetry/traces.go:40:3: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
grpc.WithBlock(),
^
internal/a3m/client.go:21:15: SA1019: grpc.DialContext is deprecated: use NewClient instead. Will be supported throughout 1.x. (staticcheck)
conn, err := grpc.DialContext(
^
Is your request related to a problem? Please describe.
After upgrading
google.golang.org/grpc
fromv1.63.2
tov1.65.0
, a couple of deprecation warnings are being reported bygolangci-lint
:More info about the deprecation:
DialContext
andDial
is not mentioned in 1.63.0 release notes grpc/grpc-go#7090Describe the solution you'd like
For now, after the changes in #1011, we are ignoring those warnings. But we should consider using
grpc.NewClient
, which raises a couple of questions:Describe alternatives you've considered
Keep ignoring the warning until we upgrade
google.golang.org/grpc
to version 2.x.The text was updated successfully, but these errors were encountered: