Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py needs to specify encoding when reading README.rst #600

Closed
andrewmwilson opened this issue Jun 4, 2019 · 5 comments · Fixed by #601
Closed

setup.py needs to specify encoding when reading README.rst #600

andrewmwilson opened this issue Jun 4, 2019 · 5 comments · Fixed by #601
Labels

Comments

@andrewmwilson
Copy link
Contributor

I've found another issue with the recent changes to setup.py (2e5031b)

Depending on the current locale, installation fails when setup.py attempts to read README.rst

Collecting arrow<1,>=0 (from this-is-redacted==1.2.3->also-redacted==4.5.6)
  Downloading https://files.pythonhosted.org/packages/90/7f/7fd8accc23aa507d215b5f07b509661c31583010d8276ba844896ee1f44b/arrow-0.14.1.tar.gz (102kB)
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-3mcnwe97/arrow/setup.py", line 7, in <module>
        readme = f.read()
      File "/apps/api/venv_py3/lib/python3.5/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xec in position 3701: ordinal not in range(128)

Also see:
#202
#208
#224

@andrewmwilson
Copy link
Contributor Author

Sorry to do this to you @jadchaar!

@andrewmwilson
Copy link
Contributor Author

I will open a PR very shortly.

@jadchaar
Copy link
Member

jadchaar commented Jun 4, 2019

No problem @andrewmwilson thanks for bringing this up. Hah the seemingly innocuous change seemed to cause the most issues.

@jadchaar
Copy link
Member

jadchaar commented Jun 4, 2019

@andrewmwilson arrow 0.14.2 has been released to address this issue. Let us know if it fixes the issue and if you have anymore questions or concerns!

@andrewmwilson
Copy link
Contributor Author

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants