Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NonFatalJvmTest from Kotest Plugin to Kotlin-test runtime #3178

Closed
nomisRev opened this issue Oct 19, 2023 · 0 comments
Closed

Refactor NonFatalJvmTest from Kotest Plugin to Kotlin-test runtime #3178

nomisRev opened this issue Oct 19, 2023 · 0 comments
Labels
2.0.0 Tickets / PRs belonging to Arrow 2.0 hacktoberfest

Comments

@nomisRev
Copy link
Member

Arrow is migrating from the Kotest Multiplatform plugin to Kotlin-test,
not because we don't love Kotest but because Arrow wants to support experimental targets like wasm and be buildable and testable with Kotlin EAP & DEV version such that we can help the Kotlin team prevent regression. We're continue using Kotest property testing, and Kotest assertions.

Arrow needs the help of the community to do this, and the Arrow maintainers will be more than happy to help you through the progress.

This ticket requires following changes in NonFatalJvmTest.kt. Here is a small list of things to do:

  1. Fork & clone the Arrow repository
  2. Checkout the arrow-2 branch and create a new branch from it.
  3. Replace all tests with shape "name of test {" to camelCase/dromedaryCase @Test fun nameOfTest() = runTest { in the test class
  4. Remove StringSpec as the super class from the test class
  5. Run ./gradlew spotlessApply
  6. Commit your changes, and push the new branch to your repo
  7. Create a PR on the Arrow repository from your branch targetting arrow-2.

Arrow really appreciates all the help, and looks forward to a bright future together in Kotlin :party:

Thanks in advance!

@nomisRev nomisRev added 2.0.0 Tickets / PRs belonging to Arrow 2.0 hacktoberfest labels Oct 19, 2023
@serras serras closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.0 Tickets / PRs belonging to Arrow 2.0 hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants